Honor tag creation date properly#3914
Closed
clintonsteiner wants to merge 7 commits intojenkinsci:masterfrom
Closed
Honor tag creation date properly#3914clintonsteiner wants to merge 7 commits intojenkinsci:masterfrom
clintonsteiner wants to merge 7 commits intojenkinsci:masterfrom
Conversation
* "Ignore tags older than" field was using the commit creation
date rather than the tag creation date.
* Change correctly distinguishes between:
- Annotated tags → Uses tag creation time (fixes the bug)
- Lightweight tags → Uses commit time (backward compatible)
This enables the "Ignore tags older than" feature to work correctly when new tags are created on old commits.
Fixes:
* jenkinsci#3731
* jenkinsci/basic-branch-build-strategies-plugin#268
clintonsteiner
force-pushed
the
fixTagTimeStampNotHonored
branch
from
a182df7 to
c44ac0f
Compare
* updates git-client used, which fixes test failures around git whatchanged * 'git whatchanged' is nominated for removal. hint: You can replace 'git whatchanged <opts>' with: hint: git log <opts> --raw --no-merges hint: Or make an alias: hint: git config set --global alias.whatchanged 'log --raw --no-merges' If you still use this command, here
Author
|
Squashed in #3916 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing done
Wrote new unittests
Submitter checklist