-
Notifications
You must be signed in to change notification settings - Fork 60
Swift testing conversion #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5979592
started on a claude.md and converting a couple tests
watkyn 0da611b
added plan
watkyn 79bb27e
phase 3 done
pmoprhy b3385d0
phase 4
pmoprhy ddbf5ed
phase 5
pmoprhy 46115ea
phase 6
pmoprhy 7de8797
phase 7
pmoprhy 872f850
Merge branch 'master' of github.com:jamf/PPPC-Utility into swift-test…
pmoprhy fef7c5a
swift format
watkyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # PPPC Utility | ||
|
|
||
| ## Swift Concurrency | ||
|
|
||
| - `SWIFT_DEFAULT_ACTOR_ISOLATION = MainActor` is set on both app and test targets — don't add explicit `@MainActor` to production code or test structs/functions, it's already the default | ||
|
|
||
| ## Swift Testing Migration | ||
|
|
||
| - Place `@Test` and `@Suite` annotations on the line **above** the declaration, not inline | ||
| - Use `// when` and `// then` comment blocks; skip `// given` (assumed from context) | ||
| - When XCTest assertions have message strings, preserve them as `#expect` messages, not code comments (e.g. `#expect(x == false, "reason")`) | ||
| - Avoid `#require` on `Bool?` — it's ambiguous; use `#expect(x == true)` instead | ||
| - Capture a baseline of compiler warnings before each phase, then verify no new warnings after. Use this command and compare the output before/after: | ||
| ``` | ||
| xcodebuild clean build-for-testing -project "PPPC Utility.xcodeproj" -scheme "PPPC Utility" -destination "platform=macOS" 2>&1 | grep -i "warning:" | grep -v "xcodebuild: WARNING" | ||
| ``` | ||
| - Use parameterized tests with Traits where it reduces duplication; 1–2 args is ideal, max 3 | ||
| - Beyond 3 params: create separate tests with some values hard-coded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.