Conversation
There was a problem hiding this comment.
Pull request overview
Migrates the existing PPPC Utility unit test suite from XCTest to Swift Testing as part of an incremental conversion plan, while adding repository documentation to standardize future migrations.
Changes:
- Converted multiple test files from
XCTestCase/XCTAssert*to Swift Testing@Suite/@Testwith#expect/#require. - Updated test resource-loading patterns to work without
self/XCTestCase(bundle locator approach). - Added migration plan documentation and Swift Testing conventions (CLAUDE.md), plus adjusted Xcode project signing settings.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| PPPC UtilityTests/TCCProfileImporterTests/TCCProfileTests.swift | Converted TCC profile serialization tests to Swift Testing; updated resource loading. |
| PPPC UtilityTests/TCCProfileImporterTests/TCCProfileImporterTests.swift | Converted importer tests to Swift Testing; updated resource URL lookup to #require. |
| PPPC UtilityTests/NetworkingTests/TokenTests.swift | Converted token validity/decoding tests to Swift Testing (#expect, #require). |
| PPPC UtilityTests/NetworkingTests/NetworkAuthManagerTests.swift | Converted async/auth error-path tests to Swift Testing, using #expect(throws:). |
| PPPC UtilityTests/NetworkingTests/JamfProAPIClientTests.swift | Converted request-building test to Swift Testing. |
| PPPC UtilityTests/ModelTests/SemanticVersionTests.swift | Converted semantic version comparison tests to Swift Testing. |
| PPPC UtilityTests/ModelTests/PPPCServicesManagerTests.swift | Converted services manager tests to Swift Testing; replaced unwrap assertions. |
| PPPC UtilityTests/ModelTests/ModelTests.swift | Converted comprehensive model tests to Swift Testing; introduced one parameterized test. |
| PPPC Utility.xcodeproj/project.pbxproj | Adjusted code-signing settings (tests and app targets). |
| docs/plans/xctest-to-swift-testing-migration.md | Added a phased migration plan and conversion patterns reference. |
| CLAUDE.md | Added repo-specific Swift concurrency + Swift Testing migration guidelines. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ing-conversion # Conflicts: # PPPC UtilityTests/ModelTests/ModelTests.swift # PPPC UtilityTests/ModelTests/PPPCServicesManagerTests.swift
seth-w-gilbert
approved these changes
Apr 2, 2026
jjpritzl
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XCTest → Swift Testing Migration Plan
Problem
Convert 52 test methods across 8 test files (plus 2 helpers) from XCTest to Swift Testing. The migration should be incremental and phased, starting with one file to establish patterns and build context.