Skip to content

Conversation

@jakobj
Copy link
Owner

@jakobj jakobj commented May 16, 2018

This PR change the call of the objective function in snes to provide generation and invidividual id to the objective functions. This information is required, for example, to set random seeds within the objective function. @mschmidt87 please have a look at this.

@jakobj jakobj changed the title Provide generation and individual id to objective in snes [WIP] Provide generation and individual id to objective in snes May 16, 2018
@jakobj
Copy link
Owner Author

jakobj commented Jul 2, 2018

regarding your comment in #5: to reduce complexity (using inspect), i would like to avoid a check like this. the only drawback for the user if they do not need individual and/or generation would be that they need to capture those values in the function call: def objective(z, *args) instead of def objective(z). i think the advantages of having these values available if requires outweigh the disadvantages here

This was referenced Jul 2, 2018
@jakobj jakobj changed the title [WIP] Provide generation and individual id to objective in snes Provide generation and individual id to objective in snes Jul 13, 2018
@mschmidt87
Copy link
Contributor

mschmidt87 commented Jul 31, 2018

I agree with you, after all, your solution seems simpler, therefore approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants