Enh/logging #9
Open
Enh/logging #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschmidt87
suggested changes
Jul 31, 2018
Contributor
mschmidt87
left a comment
mschmidt87
left a comment
There was a problem hiding this comment.
Nice work. Just one minor comment.
| n_total_individuals = population_size * (1 + int(mirrored_sampling)) | ||
| logger.info('starting evolution with {} individuals per generation on {} threads'.format(n_total_individuals, parallel_threads)) | ||
| if (parallel_threads is None and n_total_individuals > 1) or (parallel_threads is not None and n_total_individuals > parallel_threads): | ||
| logger.warning('more individuals than parallel threads. expect long runtime') |
Contributor
There was a problem hiding this comment.
"expect long runtime" sounds a bit casual. What about
"more individuals ({}) than parallel threads ({}). consider increasing the number of parallel threads.".format(n_total_individuals, parallel_threads)
Contributor
There was a problem hiding this comment.
Is it a convention to use only lowercase in logging messages?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add simple logging to snes. In addition to the screen output a log file is written according to the verbosity level given by the user. Please have a look @mschmidt87
Branches of from #4, so should not be merged before.