Skip to content

Update to crystal 1.0.0#2005

Closed
tenpura-shrimp wants to merge 2 commits intoiv-org:masterfrom
tenpura-shrimp:upddat
Closed

Update to crystal 1.0.0#2005
tenpura-shrimp wants to merge 2 commits intoiv-org:masterfrom
tenpura-shrimp:upddat

Conversation

@tenpura-shrimp
Copy link

@TheFrenchGhosty TheFrenchGhosty added blocked require something else first need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something labels Apr 13, 2021
@lzap
Copy link

lzap commented May 4, 2021

Protodec has been archived?! What happened? There is no explanation in the README.

@syeopite syeopite requested a review from saltycrys May 18, 2021 11:52
@SamantazFox
Copy link
Member

@tenpura-shrimp can you please re-do omarroth/protodec#1 against iv-org/protodec ?

@tenpura-shrimp
Copy link
Author

actually after testing this pr has issues with cookie encoding changes due to crystal 1.0.0, so it should not be merged.

@tenpura-shrimp tenpura-shrimp deleted the upddat branch May 20, 2021 18:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

blocked require something else first need-code-review A crystal developper need to check if the code is correct. need-testing This feature needs to be deployed and tested to see if it's working, and doesn't break something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants