Merged
Conversation
Member
|
Can you rebase this PR? |
Member
|
In testing on https://yewtu.be. @syeopite we should update lsquic so that it support crystal 1.0.0 too. The first major annoyance of this upgrade is that every old cookies were invalid and required me to login back. Apart from that everything is fine. |
Member
|
I think you can switch to lsquic |
Member
Can you create a PR in order to fix that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #2005 with the cookie errors fixed. #2085 should be merged before this one as well.
The only dependency that needs to be bumped here is lsquic.cr but the status of #2112 would determine if this is necessary.