Skip to content

Upgrade to crystal 1.0.0#2115

Merged
syeopite merged 5 commits intoiv-org:masterfrom
syeopite:crystal-1.0.0-2
Jun 10, 2021
Merged

Upgrade to crystal 1.0.0#2115
syeopite merged 5 commits intoiv-org:masterfrom
syeopite:crystal-1.0.0-2

Conversation

@syeopite
Copy link
Member

@syeopite syeopite commented May 24, 2021

This PR is based on #2005 with the cookie errors fixed. #2085 should be merged before this one as well.

The only dependency that needs to be bumped here is lsquic.cr but the status of #2112 would determine if this is necessary.

@unixfox
Copy link
Member

unixfox commented Jun 8, 2021

Can you rebase this PR?

@unixfox unixfox added the in-testing This feature has been deployed and is being tested label Jun 8, 2021
@unixfox
Copy link
Member

unixfox commented Jun 8, 2021

In testing on https://yewtu.be. @syeopite we should update lsquic so that it support crystal 1.0.0 too.

The first major annoyance of this upgrade is that every old cookies were invalid and required me to login back. Apart from that everything is fine.

@unixfox
Copy link
Member

unixfox commented Jun 10, 2021

I think you can switch to lsquic v2.18.1-2 and this should be good to be merged.

@syeopite syeopite merged commit a6e38e2 into iv-org:master Jun 10, 2021
@unixfox
Copy link
Member

unixfox commented Jun 10, 2021

We want to decode env.request.cookies["PREFS"], not the whole expression! That's why CI doesn't pass:

Preferences.from_json(
  URI.decode_www_form(env.request.cookies["PREFS"])?
    .try &.value
  || "{}"
)

Can you create a PR in order to fix that?

@syeopite syeopite deleted the crystal-1.0.0-2 branch June 13, 2021 14:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

in-testing This feature has been deployed and is being tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants