Conversation
This enables arbitrary modes of pinning to be added in the future. Third type name 'pinset' could represent object storing all local pins.
| format: int32 | ||
| default: -1 | ||
| minimum: -1 | ||
| mode: |
There was a problem hiding this comment.
avoided type because its often a restricted keyword
|
I think
|
|
Similarly to how pinning services handle depth (they don't) I'm pretty sure all pinning services (including Pinata) assume every pin is recursive in nature and I'm not aware of any service that specifically allows for direct pins. This may be another filter that isn't needed. |
|
Thanks! Sounds like we can close this in favor of (optional) #19 |
This PR removes ambiguity of
depth: -1for recursive pins (cc @ achingbrain) and enables arbitrary modes of pinning to be added in the future.I included the third type named 'pinset', which could represent a well-known format for storing all local pins (cc @aschmahmann, we discussed something like this last week), but we can remove it if its not feasible atm.
cc @obo20