Skip to content

Replace Pin.depth with Pin.recursive boolean#17

Closed
lidel wants to merge 1 commit intomasterfrom
refactor/recursive-pins
Closed

Replace Pin.depth with Pin.recursive boolean#17
lidel wants to merge 1 commit intomasterfrom
refactor/recursive-pins

Conversation

@lidel
Copy link
Member

@lidel lidel commented Jul 10, 2020

See also #16 for more flexible enum version.

This PR simplifies Pin object to only support what currently exists.

This simplifies Pin object to only support what currently exists.
@obo20
Copy link

obo20 commented Jul 10, 2020

Similarly to how pinning services handle depth (they don't) I'm pretty sure all pinning services (including Pinata) assume every pin is recursive in nature and I'm not aware of any service that allows for direct pins. This may be another filter that isn't needed.

@lidel
Copy link
Member Author

lidel commented Jul 13, 2020

Thanks! closing as not needed.

@lidel lidel closed this Jul 13, 2020
@lidel lidel deleted the refactor/recursive-pins branch July 13, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants