This repository was archived by the owner on Feb 12, 2024. It is now read-only.
Closed
Conversation
42 tasks
This was referenced Dec 13, 2019
achingbrain
reviewed
Dec 13, 2019
| const out = await ipfs('bitswap unwant ' + key0) | ||
| expect(out).to.eql(`Key ${key0} removed from wantlist\n`) | ||
| }) | ||
| // TODO: missing unwant with cid-base arg |
Member
There was a problem hiding this comment.
There are quite a lot of TODOs being added here - how will they be resolved? By adding tests to these suites or the interface tests?
Member
Author
There was a problem hiding this comment.
everything related to cli logic will be added to js-ipfs cli suite, everything that needed to be extracted to interface-core is already ipfs-inactive/interface-js-ipfs-core#573.
The comments may refer to new tests that need to be added by the follow up PRs but this is only related to the CLI tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of this OKR #2276 and will dedupe tests as much as possible to interface-core.
dedupe:
refs:
ipfs-inactive/interface-js-ipfs-core#573
ipfs-inactive/js-ipfs-http-client#1200