This repository was archived by the owner on Mar 10, 2020. It is now read-only.
Open
Conversation
42 tasks
This was referenced Dec 13, 2019
Collaborator
|
Is there some way of comparing coverage before/after to make sure nothing is missed in these PRs? |
Contributor
Author
|
Yes check codecov in the http-client PR apparently we lost these 2 bits https://codecov.io/gh/ipfs/js-ipfs-http-client/compare/23421f397e4ae80ac9e9264ee6662b2cc0e34791...2e30f994459a038fc4665890101a23beafcd0f71/changes |
Contributor
Author
|
In js-ipfs And the follow up cli tests PRs will increase the cov more. |
Contributor
Author
|
added a new test for the validation in dag.get |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR supports the deduping of tests in ipfs-http-client and js-ipfs.
Tests will be added here and removed in both repos.
changes to subsystems
refs:
ipfs-inactive/js-ipfs-http-client#1200
ipfs/js-ipfs#2669