versions: add support for version checks via pyproject.toml #386
Conversation
max-moser
force-pushed
the
mm/version-check-fix
branch
from
48957ea to
b555eb2
Compare
invenio_cli/helpers/versions.py
Outdated
| import os | ||
| import re | ||
|
|
||
| import tomli |
There was a problem hiding this comment.
tomllib is part of the standard lib starting with python 3.11, but until then we can use tomli which is a dependency from somewhere (pipfile?)
There was a problem hiding this comment.
Maybe we add a direct dependency to tomllib with a Python version specifier? On my machine I get just a toml dependency when e.g. running on Python 3.9:
toml v0.10.2
└── pipfile v0.0.2 [requires: toml *]
└── invenio-cli v1.6.0 [requires: pipfile >=0.0.2]
There was a problem hiding this comment.
right, i actually forgot that you can add dependencies for specific python versions only
There was a problem hiding this comment.
leaving this here for now: https://github.com/hukkin/tomli?tab=readme-ov-file#building-a-tomlitomllib-compatibility-layer
* previously, only `Pipfile` was considered, which only supports `pipenv` but not `uv`
max-moser
force-pushed
the
mm/version-check-fix
branch
from
b555eb2 to
454b480
Compare
There was a problem hiding this comment.
merged ils.py and rdm.py into this one
|
briefly discussed with @ntarocco ✔️ |
2 participants
This PR should've been part of #384 but was overlooked.
It adds support for parsing the
App-{RDM,ILS}dependency version frompyproject.toml.