Skip to content

Conversation

@karkraeg
Copy link
Member

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

After enabling users to use uv and pyproject.toml instead of pipenv and Pipfile invenio-cli services setup fails when no Pipfile is present anymore. This PR introduces a tooling-agnostic way of determining the app-rdm Version number from either Pipfile or pyproject.toml.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

@utnapischtim
Copy link
Contributor

is that the same as #386

@karkraeg
Copy link
Member Author

jepp, didn't see that one which is more complete than mine. It's only that for now with 1.6.0 you cant setup a RDM instance with uv tooling as the services won't start, so it would be nice to release #389 sooner than later =)

@karkraeg karkraeg closed this Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants