-
Notifications
You must be signed in to change notification settings - Fork 45
uv rspack pnpm web worker ports #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
utnapischtim
wants to merge
24
commits into
inveniosoftware:master
from
utnapischtim:uv-rspack-pnpm-web-worker-ports
Closed
uv rspack pnpm web worker ports #383
utnapischtim
wants to merge
24
commits into
inveniosoftware:master
from
utnapischtim:uv-rspack-pnpm-web-worker-ports
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Explicitly makes the Celery worker listen to the "default" and "low" queues.
* since rspack configuration is not more in webpack.config.js this is necessary
This was referenced Feb 19, 2025
Closed
* since uv uses pyproject.toml relying on Pipfile doesn't work
* handle the detection of the python package manager to be used and the generation of its commands in a central spot to lower the maintenance burden * make some commands (like translations) aware of the CLI config, to enable using pipenv alternatives too
* also rename packages_manager to package_manager because that's the common term
* tell invenio about which JS package manager is actually selected currently (npm or pnpm), via the new `ASSETS_NPM_PKG_CLS` config
* it looks like there's no direct analogue in uv though, so they're implemented in shell scripts...
* put random multi-line strings into a single line * slightly reword some help text
* also, use the module_pkg to execute the install command in the target path (rather than the instance's path, which made a difference in the case of pnpm)
This was referenced Feb 28, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this supersede #380
steps to how to use it
1.) check that
uvandpnpmare installed2.) create a new my-site directory with the regular content as usual OR go into your current development my-site directory
2.a) deactivate the active environment
3.) create with uv a virtual environment with
uv venv --prompt uv-env && source .venv/bin/activate4.) install invenio-cli with
uv pip install "git+https://github.com/utnapischtim/invenio-cli@uv-rspack-pnpm-web-worker-ports"4.a)
uv pip install "git+https://github.com/utnapischtim/pynpm@add-pnpm"5.) copy following text into the
.inveniofile into the cli section5.a) please copy following to
invenio.cfg6.) copy following text into the
pyproject.tomlfile. the file should be created beside theinvenio.cfgfile7.) run invenio-cli install to install