-
Notifications
You must be signed in to change notification settings - Fork 45
WIP merged up uv ports branches #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
utnapischtim
wants to merge
36
commits into
inveniosoftware:master
from
utnapischtim:WIP-merged-up-uv-ports-branches
Closed
WIP merged up uv ports branches #380
utnapischtim
wants to merge
36
commits into
inveniosoftware:master
from
utnapischtim:WIP-merged-up-uv-ports-branches
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this gives a huge performance improvement on installing and setting up an environment.
* Explicitly makes the Celery worker listen to the "default" and "low" queues.
* the problem was that the packages which are installed editable and will be used on the assets build step arent't found if the assets build method is called during the invenio-cli install command.
* this commit assumes that the instance path isn't customizable and therefore removes the necessity of starting up the app to get the instance path. * the case where the instance path is overridable should be handled in another commit.
d9fc688 to
128053b
Compare
* the attempt to use invenio_cli to be faster fasn't successful
94f5361 to
79603c3
Compare
* the instance should be set if it is not present in the .invenio.private file. it has to be collected from the app
79603c3 to
bc977c8
Compare
* to create the assets create_ui is enough. the assets only need the blueprints and they exists in create_ui. creat_ui only creates one app and not two as create_app does
5 tasks
d3354ab to
f48e721
Compare
* since rspack configuration is not more in webpack.config.js this is necessary
f48e721 to
5ddbc3f
Compare
Contributor
|
for the record, the configuration needs to be added into the [cli]
flavour = RDM
logfile = /logs/invenio-cli.log
javascript_packages_manager = pnpm
python_packages_manager = uv
|
max-moser
reviewed
Feb 18, 2025
* the command is for both assets builder the same, because the configuration has been moved to another place
466efff to
f5a6949
Compare
max-moser
reviewed
Feb 19, 2025
1ef694e to
3c96ce3
Compare
* change in flask
* this enables again the option to have invenio-cli installed globally
* there are use cases where the instance_path needs to be updated, it is safer to run that every time
3c96ce3 to
f483fc1
Compare
Contributor
Author
|
superseded by #383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a combination of
this PR should not be merged as it is. it is a starting point to discuss improvements!
discussion points
some arguable (provoking) performance improvements e.g.reverted. setting it over the invenio call is necessaryshould we go in and change without backwards compatibility to uv + rspack + pnpm?no, it will be configurable which tools will be used by the developermaking python packages manager configurable would keep invenio-cli backwards compatible commityesmaking javascript packages manager configurable would keep invenio-cli backwards compatible commit needs commityesmaking assets builder configurable would keep invenio-cli backwards compatible commit needs commit invenio-assets commit has to be finished if we use the approach (webpack.config.js has to be reverted back to real webpack configuration)yessys.path.insertlikesteps to how to use it
1.) check that
uvandpnpmare installed2.) create a new my-site directory with the regular content as usual OR go into your current development my-site directory
2.a) deactivate the active environment
3.) create with uv a virtual environment with
uv venv --prompt uv-env && source .venv/bin/activate4.) install invenio-cli with
uv pip install "git+https://github.com/utnapischtim/invenio-cli@WIP-merged-up-uv-ports-branches"5.) copy following text into the
.inveniofile into the cli section5.a) please copy following to
invenio.cfg6.) copy following text into the
pyproject.tomlfile. the file should be created beside theinvenio.cfgfile7.) run time invenio-cli install to install and to see how long it takes
8.) run time invenio-cli install again to see the behavior with hot cache