Skip to content

refactor: Adopt new throwing AVAssetExportSession export function #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbmorley merged 4 commits into from
Jan 23, 2026
Merged

refactor: Adopt new throwing AVAssetExportSession export function #312

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ede4465
fix: Address intermittent hangs when importing movies
jbmorley Jan 23, 2026
1cf5096
Remove defunct code
jbmorley Jan 23, 2026
16e1bb1
No longer necessary to set properties
jbmorley Jan 23, 2026
8f6cb74
Merge remote-tracking branch 'origin/main' into jbmorley/ensure-video…
jbmorley Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Sources/InContextCore/Importers/VideoImporterMac.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,11 +171,9 @@ extension VideoImporter: Importer {
presetName: preset) else {
throw InContextError.internalInconsistency("Failed to create export session.")
}
exportSession.outputFileType = outputFileType
exportSession.outputURL = outputURL

// Convert the video to the output file type and export it to the output URL.
await exportSession.export()
try await exportSession.export(to: outputURL, as: outputFileType)
}

}
Expand Down