refactor: Adopt new throwing AVAssetExportSession export function
#312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like a now-deprecated `AVKit` export API would hang if it ever encountered an error, leading to hangs in site builds. This change adopts the new throwing API to ensure these hangs don’t occur any more. Unfortunately the export API itself seems to be entirely non-deterministic (especially on Tahoe?) and fails randomly, so now, builds will just fail instead. I guess that’s progress? 🤦
jbmorley
changed the title
jbmorley
changed the title
jbmorley
changed the title
AVAssetExportSession export method
jbmorley
changed the title
AVAssetExportSession export methodAVAssetExportSession export function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple have deprecated the previous function in favor of a new throwing one. Since I encountered this while trying to root-cause the video conversion hangs, I figured I should use the new one. Sadly, in spite of my initial assessment, it does not do anything to resolve the hangs.