Authentication commands implemented#155
Open
tolbxela wants to merge 5 commits intoinflatablefriends:nextfrom
Open
Authentication commands implemented#155tolbxela wants to merge 5 commits intoinflatablefriends:nextfrom
tolbxela wants to merge 5 commits intoinflatablefriends:nextfrom
Conversation
tolbxela
commented
Mar 31, 2020
tolbxela
commented
- auth.getToken (Implement command auth.getToken #154)
- auth.getSession (Implement command auth.getSession #153)
* TrackUpdateNowPlayingCommand: some values were emptyed * GetWeeklyAlbumChartAsync and GetWeeklyArtistChartAsync were done without parameter "to" * UserGetWeeklyTrackChartTests was commented out, since it's bad test now and should be done another way (see my comment in the file) * ScrobblesSingle: trackPlayed and scrobbledTrack.TimePlayed are different, when it took to much time to test the solution. The line was commented out.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.