Open
Conversation
* TrackUpdateNowPlayingCommand: some values were emptyed * GetWeeklyAlbumChartAsync and GetWeeklyArtistChartAsync were done without parameter "to" * UserGetWeeklyTrackChartTests was commented out, since it's bad test now and should be done another way (see my comment in the file) * ScrobblesSingle: trackPlayed and scrobbledTrack.TimePlayed are different, when it took to much time to test the solution. The line was commented out.
Auth methods
Member
|
Hi @kapral. Thanks for your interest in this project. Basically what's stopping me merging any of the open PRs is that the CI checks are not running successfully on them - there's something misconfigured with GitHub Actions. I haven't had time to debug or fix this due to other commitments, and also don't have time to test each PR manually myself. If you are able to run tests manually and show they're passing (screenshot of test results or something), or fix the GitHub Actions config, then I'll happily merge branches, then make some time to update the NuGet packages. Cheers |
Author
|
Hey @rikkit! Since the actions were fixed and I upgraded, can this be merged now (and package released)? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #155 hasn't been merged for a while assuming because of the failed build due to failing tests on
masterbranch.As far as I can see all recent development is done on the
nextbranch so I'm just re-submitting same changes to that branch.If everything is alright, what is a chance of getting a nuget package with this changes soon?