Open
Conversation
Collaborator
|
I'm happy with this in principle, but I don't know javascript well enough to review. I'd also like some automated tests so we can make sure this continues to work correctly for both standard django and django with grappelli. @meshy Any thoughts? |
Collaborator
There was a problem hiding this comment.
I wonder -- is there a less aggressive way than !important to get this to work?
Collaborator
|
@Apkawa thanks for this! @ian-foote I think that front-end tests are a good plan too -- this project is probably a good candidate for selenium or similar. |
maxpeterson
approved these changes
Mar 9, 2018
2 tasks
Member
|
Not really sure why this was never merged? |
Collaborator
|
Probably because the tests for it never happened. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
django-grappelli.readthedocs.org/en/latest/