Conversation
meshy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
=======================================
Coverage 86.09% 86.09%
=======================================
Files 4 4
Lines 151 151
=======================================
Hits 130 130
Misses 21 21Continue to review full report at Codecov.
|
meshy
force-pushed
the
behave
branch
2 times, most recently
from
953de5e to
54f9b5d
Compare
meshy
commented
Oct 28, 2018
| @given(u'the following items') | ||
| def set_up_items(context): | ||
| Item.objects.bulk_create([ | ||
| Item(pk=row['pk'], sort_order=i) |
Collaborator
Author
There was a problem hiding this comment.
This needs to be i+1, to avoid populating the item with a 0 (which is not a valid value).
meshy
commented
Oct 28, 2018
| @@ -0,0 +1,11 @@ | |||
| from .browser import Browser | |||
| from .pages import ItemListPage | |||
Collaborator
Author
There was a problem hiding this comment.
Tests fail because this isn't an acceptable relative import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an initial selenium test for the django admin code. It's part of #30 (add selenium tests), and paves the way towards addressing #32 (remove custom admin template). Hopefully, it'll also make #15 (disable drag-and-drop with other orderings) easier to tackle, and #29 (django-grapelli integration) easier to verify.
This builds on the work in PR #49, so once that's merged, I'll rebase this to make it easier to review
TODO: