Draft
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
❌ Visual Diff Report — FAILED768 images compared: 143 different · 625 identical DetailsDifferences (143)
Download the results. |
Member
|
first feedback item: section title label cannot be "independent learning" - which carries a separate meaning (and has its own session type). ILM is really "self-contained asynchronous learning activity found external to the system with a specific expectation of time involvement for the learner" which obviously is a mouthful, but the reason we go shorthand with "ILM"... second item: deletion message needs to be specific to the ILM module, since deletion of the ILM does not remove any offerings/groups also associated with the session if they exist. Points for discussion as it will have impact on any changes or additions to translations and labels. |
jrjohnson
force-pushed
the
i4316-ilm-management
branch
2 times, most recently
from
7f665a7 to
e841aa3
Compare
To make ILM management in a session easier I've wrapped everything in a fieldset and added a confirmation step for removing ILMs.
jrjohnson
force-pushed
the
i4316-ilm-management
branch
from
e841aa3 to
4ee145b
Compare
Member
|
Member
|
I moved "Due Prior to" into the ILM area and am suggesting moving the instructors and learners - groups and individuals into that area too - anything that pertains to the ILM should be moved there in my opinion. |
Member
|
Maybe a reformatting of the manage components inside of the ILM frame could be beneficial too - move Manage buttons to left maybe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make ILM management in a session easier I've wrapped everything in a fieldset and added a confirmation step for removing ILMs.
Wip:
addIlm: Add ILM to {session}confirmRemoveIlm: "Are you sure you want to delete this ILM? This action cannot be undone and will remove all learners and instructors linked directly to this session."and translation.Fixes ilios/ilios#4316