You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
<ToggleYesNo> was only disabled conditionally in one other part of the site, but the component itself has no code to use a @disabled argument, thus this fixes the issue and adds it.
However, what should a disabled toggle look like? And what should the tooltip/message say to warn users when it's disabled?
I made a decision about the disabled-ness of the button, but the tooltip/message is still up for grabs. Feedback welcome!
Hmm. a couple points. First, this is going to wildly irritate any user who has activated the ILM toggle but needs to flip it back to a regular session. Next, the error message will need to state clearly all the values / attributes that need removal in order to deactivate the toggle. Ideally, the message will also include a "Click here to remove all groups and instructors" type link in order to keep the users from having to navigate to user management and clickety click. That said, the visual toggle is fine, and we can discuss and address the above thoughts at jam.
Partial team discussion conclusion: get full team consensus on potential alternative direction for this fix. Idea brought up: remove toggle entirely, make it a "change this to ILM" button with local restrictions, move "Due prior" to different section since it's not tied to toggle logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#4316
<ToggleYesNo>was only disabled conditionally in one other part of the site, but the component itself has no code to use a@disabledargument, thus this fixes the issue and adds it.However, what should a disabled toggle look like? And what should the tooltip/message say to warn users when it's disabled?
I made a decision about the disabled-ness of the button, but the tooltip/message is still up for grabs. Feedback welcome!