Disable multisampled textures, glTexImage2DMultisample#447
Merged
Conversation
Steven used multisampled textures from the beginning, but this caused incompatibilities: Thinkofname/steven#74. Subsequently fixed by increasing the number of samples, but increasing it beyond the limit caused more incompatibilities, so it was clamped to the maximum samples reported as supported by the system. Fast-forward to now, as part of adding WebGL support (#446), the use of multisampled textures via the glTexImage2DMultisample() call is unsupported on this platform. Replace the following: * glTexImage2DMultisample -> glTexImage2D * TEXTURE_2D_MULTISAMPLE -> TEXTURE_2D * sampler2DMS -> sampler2D This disables the custom multisampling anti-aliasing algorithm (MSAA) implemented in the chunk fragment shader, increasing compatibility: * Update to glow release, remove image_2d_sample() MSAA may be added back at a later date using multisampled renderbuffers instead, see #442.
This was referenced Dec 27, 2020
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steven used multisampled textures from the beginning, but this caused
incompatibilities: Thinkofname/steven#74.
Subsequently fixed by increasing the number of samples, but increasing
it beyond the limit caused more incompatibilities, so it was clamped to
the maximum samples reported as supported by the system.
Fast-forward to now, as part of adding WebGL support (#446), the use of
multisampled textures via the glTexImage2DMultisample() call is
unsupported on this platform. Replace the following:
This disables the custom multisampling anti-aliasing algorithm (MSAA)
implemented in the chunk fragment shader, increasing compatibility:
MSAA may be added back at a later date using multisampled renderbuffers
instead, see #442.