Skip to content

Conversation

@saskliutas
Copy link
Member

Bumped hierarchies and hierarchies-react version and reacted to breaking changes.

@saskliutas saskliutas requested review from a team as code owners December 12, 2025 14:03
@saskliutas saskliutas requested review from Copilot and removed request for a team December 12, 2025 14:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the codebase to be compatible with breaking changes introduced by bumping @itwin/presentation-hierarchies and @itwin/presentation-hierarchies-react dependencies. The primary change involves renaming the hierarchy filtering API from "filtering" terminology to "search" terminology to better reflect its purpose.

Key changes:

  • Renamed API methods and types from HierarchyFilteringPath to HierarchySearchPath throughout the codebase
  • Updated property names from getFilteredPaths to getSearchPaths
  • Changed node properties from filtering to search (including nested properties like isFilterTargetisSearchTarget)

Reviewed changes

Copilot reviewed 33 out of 35 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json files Updated dependency versions to alpha.4/5/8/47 releases
Tree visibility handlers Renamed HierarchyFilteringPath type to HierarchySearchPath
Tree component props Changed getFilteredPaths prop to getSearchPaths
Tree definitions Updated filtering method names and types to use "search" terminology
Utility functions Renamed joinHierarchyFilteringPaths to joinHierarchySearchPaths
Node utilities Changed filtering property to search with corresponding nested property updates
Test files Updated test assertions and mock data to use new search terminology
Files not reviewed (2)
  • apps/test-viewer/pnpm-lock.yaml: Language not supported
  • packages/itwin/tree-widget/pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@saskliutas saskliutas requested a review from a team December 12, 2025 14:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tree-Widget Next benchmark

Benchmark suite Current: 6e2b382 Previous: e7b7272 Deviation Status
categories tree creates initial filtered view for 50k items 1514.92 ms 1428.97 ms 6.01% 〰️
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) 156 ms 175 ms -10.86% 〰️
categories tree changing definition container visibility changes visibility for 50k subCategories 5540.02 ms 6900.52 ms -19.72%
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) 3546 ms 4869 ms -27.17%
categories tree changing definition container visibility changes visibility for 50k categories 10930.26 ms 10687.34 ms 2.27% 〰️
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) 430 ms 453 ms -5.08% 〰️
classifications tree loads initial view for iModel with 50k classifications 40.44 ms 40.78 ms -0.83% 〰️
classifications tree loads initial view for iModel with 50k classifications (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
classifications tree loads first branch for iModel with 50k classifications 1359.72 ms 1420.32 ms -4.27% 〰️
classifications tree loads first branch for iModel with 50k classifications (P95 of main thread blocks) 169 ms 195 ms -13.33% 〰️
models tree creates initial filtered view for 50k target items 943.22 ms 951.82 ms -0.90% 〰️
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) 110 ms 110 ms 0% 🟰
models tree changing model visibility changes visibility for 50k elements 2011.96 ms 2196.91 ms -8.42% 〰️
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing category visibility changes visibility for 50k elements 1985.19 ms 2460.85 ms -19.33%
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰
models tree changing per-model-category override changes visibility for 50k elements 1989.56 ms 2509.49 ms -20.72%
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) 0 ms 0 ms 0% 🟰

This comment was automatically generated by workflow using github-action-benchmark.

@saskliutas saskliutas merged commit a1a6c98 into tree-widget/next Dec 12, 2025
11 checks passed
@saskliutas saskliutas deleted the filter-search-rename branch December 12, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants