-
Notifications
You must be signed in to change notification settings - Fork 37
[Tree widget]: Rename filter to search #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tree-Widget Next benchmark
| Benchmark suite | Current: 89ddd05 | Previous: a1a6c98 | Deviation | Status |
|---|---|---|---|---|
categories tree creates initial filtered view for 50k items |
1523.31 ms |
1451.84 ms |
4.92% |
〰️ |
categories tree creates initial filtered view for 50k items (P95 of main thread blocks) |
155 ms |
159 ms |
-2.52% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k subCategories |
6093.16 ms |
6963.01 ms |
-12.49% |
✅ |
categories tree changing definition container visibility changes visibility for 50k subCategories (P95 of main thread blocks) |
4146 ms |
4926 ms |
-15.83% |
✅ |
categories tree changing definition container visibility changes visibility for 50k categories |
10442.05 ms |
11476.15 ms |
-9.01% |
〰️ |
categories tree changing definition container visibility changes visibility for 50k categories (P95 of main thread blocks) |
415 ms |
448 ms |
-7.37% |
〰️ |
classifications tree loads initial view for iModel with 50k classifications |
41.5 ms |
41.99 ms |
-1.17% |
〰️ |
classifications tree loads initial view for iModel with 50k classifications (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
classifications tree loads first branch for iModel with 50k classifications |
1354.94 ms |
1554.65 ms |
-12.85% |
✅ |
classifications tree loads first branch for iModel with 50k classifications (P95 of main thread blocks) |
184 ms |
177 ms |
3.95% |
〰️ |
models tree creates initial filtered view for 50k target items |
928.03 ms |
992.01 ms |
-6.45% |
〰️ |
models tree creates initial filtered view for 50k target items (P95 of main thread blocks) |
135 ms |
152 ms |
-11.18% |
〰️ |
models tree changing model visibility changes visibility for 50k elements |
2002.56 ms |
2085.59 ms |
-3.98% |
〰️ |
models tree changing model visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing category visibility changes visibility for 50k elements |
2000.36 ms |
2029.02 ms |
-1.41% |
〰️ |
models tree changing category visibility changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
models tree changing per-model-category override changes visibility for 50k elements |
1956.51 ms |
2295.99 ms |
-14.79% |
✅ |
models tree changing per-model-category override changes visibility for 50k elements (P95 of main thread blocks) |
0 ms |
0 ms |
0% |
🟰 |
This comment was automatically generated by workflow using github-action-benchmark.
JonasDov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changeset that explains API changes
...ree-widget/src/tree-widget-react/components/trees/categories-tree/internal/UseSearchPaths.ts
Outdated
Show resolved
Hide resolved
...ges/itwin/tree-widget/src/tree-widget-react/components/trees/common/components/EmptyTree.tsx
Outdated
Show resolved
Hide resolved
|
|
Follow up to #1538
Renamed
filtertosearchTexton tree APIsMade additional internal renames to match closer to the terminology in
presentation-hierarchiesandpresentation-hierarchies-react:onFilterPathsChanged->onSearchPathsChangeduseFilteredPaths->useSearchPathsFilteredTree->SearchResultsTreeBaseFilteredTreeNode->BaseSearchResultsTreeNodeFilteredTreeRootNode->SearchResultsTreeRootNodeFilteredTreeNodeChildren->SearchResultsTreeNodeChildrenFilteredNodesHandler->SearchResultsNodesHandlercreateFilteredTree->createSearchResultsTreeHierarchyVisibilityHandlerImpl.changeFilteredNodeVisibility->HierarchyVisibilityHandlerImpl.changeSearchResultsNodeVisibilityHierarchyVisibilityHandlerImplgetFilteredNodeVisibility->HierarchyVisibilityHandlerImpl.getSearchResultsNodeVisibilityjoinHierarchyFilterPaths->joinHierarchySearchPaths