Skip to content

Verify assay names #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
biobenkj merged 2 commits into from
Apr 10, 2025
Merged

Verify assay names #68

biobenkj merged 2 commits into from
Apr 10, 2025

Conversation

@jamespeapen
Copy link
Member

@jamespeapen jamespeapen commented Mar 25, 2025

  • Add a function to verify that the SE contains the right "counts" or "Beta" assay depending on the assay type
  • Move the verification function calls up the stack so errors are caught earlier and verification isn't done on the same objects multiple times.
  • This assumes that modifications like filterOpenSea don't convert the SE into something that's not an SE and that a subset of a SE is still a SE.

@jamespeapen
refactor(utils): extract assay name checks into function
321462f
@jamespeapen
refactor: move SE verifications up the call stack
da0f8d6 
if an object is verified by the parent function, it doesn't need to be
verified again. Lets us catch problems earlier and reduce verify calls
@biobenkj biobenkj merged commit 6d7ddcc into huishenlab:master Apr 10, 2025
1 check passed
@jamespeapen jamespeapen deleted the verifyAssayNames branch April 28, 2025 13:55
@jamespeapen jamespeapen added this to the v2 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v2

Development

Successfully merging this pull request may close these issues.

2 participants

@jamespeapen @biobenkj