HDPI-3769 Regular expenses#1019
Open
libanAbdirahman1 wants to merge 7 commits intoHDPI-3764-income-expenditure-frontendfrom
Open
HDPI-3769 Regular expenses#1019libanAbdirahman1 wants to merge 7 commits intoHDPI-3764-income-expenditure-frontendfrom
libanAbdirahman1 wants to merge 7 commits intoHDPI-3764-income-expenditure-frontendfrom
Conversation
Co-authored-by: PadmaDeenadayalan <Padma.Deenadayalan@hmcts.net> Co-authored-by: jessieharrigan <144362161+jessieharrigan@users.noreply.github.com> Co-authored-by: padmakumari <padma.kumari@hmcts.net> Co-authored-by: Gautham059 <gautham.bhikkumalla@hmcts.net>
…ntend' into HDPI-3769-Regular-expenses
libanAbdirahman1
changed the title
libanAbdirahman1
changed the title
…ntend' into HDPI-3769-Regular-expenses
6 tasks
libanAbdirahman1
requested review from
linusnorton and
saurabhvalsangkar-hmcts
and removed request for
a team
| moneyFromElsewhereDetails?: string; | ||
| householdBills?: YesNoValue; | ||
| householdBillsAmount?: PenceAmount; | ||
| householdBillsFrequency?: FrequencyValue; |
Contributor
There was a problem hiding this comment.
Just for discussion - what do you think about creating a new type here, (and in the backend), which represents these three types that are repeated here? (i.e. does it apply / amount / frequency)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
HDPI-3769
Change description
Regular expensespage to capture regular expenses type, amount & frequency.Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist