Open
Conversation
CCD diff summary👉 Full report: https://github.com/hmcts/pcs-api/actions/runs/23905419565?check_suite_focus=true ComplexTypes/1_HouseholdCircumstances.json
ComplexTypes/0_IncomeExpenseDetails.json
FixedLists/RecurrenceFrequency.json
|
libanAbdirahman1
requested review from
a team,
adusumillipraveen,
ayub-macalim,
linusnorton and
toby-plunkett
| @Getter | ||
| public enum RecurrenceFrequency implements HasLabel { | ||
| WEEKLY("Weekly"), | ||
| MONTHLY("Monthly"); |
Contributor
There was a problem hiding this comment.
I feel like I've seen this enum being added for a different PR in the last week...
Contributor
Author
There was a problem hiding this comment.
yes its was this Pr. I've kept this similar to that one as this frequency is used by income and expense pages.
|
|
||
| private String regularExpenses; | ||
|
|
||
| //Columns to drop |
Contributor
There was a problem hiding this comment.
Did you mean to leave this comment?
Contributor
Author
There was a problem hiding this comment.
well spotted, I intended to drop the columns which i did here
ayub-macalim
approved these changes
Apr 1, 2026
tvr-hmcts
reviewed
Apr 1, 2026
Contributor
tvr-hmcts
left a comment
tvr-hmcts
left a comment
There was a problem hiding this comment.
Just one comment on the entity - though pls check them if needed.
.../uk/gov/hmcts/reform/pcs/ccd/entity/respondpossessionclaim/HouseholdCircumstancesEntity.java
Show resolved
Hide resolved
tvr-hmcts
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira link
HDPI-3769
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist