Conversation
added 2 commits
January 14, 2020 15:31
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
cpanato
reviewed
Jan 16, 2020
Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>
Contributor
Author
|
I've added the storageclass test again using "standard" instead of "local-path". |
Contributor
Author
|
Is anything missing here to get this merged? |
Member
|
I think it looks good. |
unguiculus
requested changes
Feb 6, 2020
Member
unguiculus
left a comment
unguiculus
left a comment
There was a problem hiding this comment.
Why not just remove the local path provisioner since it is now included in kind?
Signed-off-by: André Bauer <monotek23@gmail.com>
Contributor
Author
Done |
unguiculus
approved these changes
Feb 7, 2020
Member
|
Love that this was addressed upstream 💯 Thanks @monotek |
sayboras
added a commit
to sayboras/cilium
that referenced
this pull request
May 27, 2020
There is warning message in github action as per below. ##[warning]Unexpected input 'install_local_path_provisioner' This option was removed as part of helm/kind-action#16. Underlying kind 0.7.0+ is shipped with better local storage. I take this change to upgrade kind version to latest as well Signed-off-by: Tam Mach <sayboras@yahoo.com>
aanm
pushed a commit
to cilium/cilium
that referenced
this pull request
May 27, 2020
There is warning message in github action as per below. ##[warning]Unexpected input 'install_local_path_provisioner' This option was removed as part of helm/kind-action#16. Underlying kind 0.7.0+ is shipped with better local storage. I take this change to upgrade kind version to latest as well Signed-off-by: Tam Mach <sayboras@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes not running kind jobs where the charts use persistence.
For example:
Kind fixed it by: kubernetes-sigs/kind#1157 which is in release 0.7.0