Add chart for HawkBit by axdotl · Pull Request #18 · eclipse-packages/packages

axdotl · 2020-01-09T13:20:24Z

Signed-off-by: Axel Köhler axel.koehler@kiwigrid.com

This PR will add the Hawkbit update server chart to the packages project.
Feedback is highly appreciated.

thjaeckle · 2020-01-09T13:25:05Z

Review required by @laverman as hawkBit representative in the Packages project

monotek · 2020-01-09T15:19:12Z

The problems seems to be usage of rabbitmq chart from bitnami repo, which is not added in ct.yaml
Adding bitnami repo like in the link below should do the trick:
https://github.com/kiwigrid/helm-charts/blob/master/.ci/ct.yaml#L5

laverman

Great to see this contribution here! 👍

Just some general comments:

Would you mind adding a license header to the *.yaml files?
I triggered the CI-actions again, to see if #17 fixed the failed check.
I don't want to start a big naming discussion, whether to name it "eclipse-hawkbit" or "hawkbit-update-server" ;-) However, in order to be consistent with ditto, it might make sense to go with the former (knowing that hawkBit named its docker image "hawkbit-update-server") ... What do you think?
Also in accordance with ditto, shall we add a Local Setup section to the readme as well? (Could also be part of another PR)

Please find my other comments in the respective files.

laverman · 2020-01-13T08:26:12Z

charts/hawkbit-update-server/templates/deployment.yaml

+          env:
+            - name: SPRING_PROFILES_ACTIVE
+              value: "{{ .Values.spring.profiles }}"
+            - name: MANAGEMENT_SERVER_PORT


What is this property used for?
If you want to change hawkBit's server port SERVER_PORT would be the correct property.

It configures the SpringBoot management server port. The port is used for the probes.
(ref: https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-features.html#production-ready-customizing-management-server-port)

If you agree I'll keep this confiugration.

Understood. However, as there are no actual actuator endpoints (e.g. health, metrics, ...) available, I was wondering whether to just use the hawkBit landing page for the probes?

I changed it.

laverman · 2020-01-13T08:26:46Z

charts/hawkbit-update-server/templates/deployment.yaml

+            - name: http
+              containerPort: 8080
+              protocol: TCP
+            - name: management


laverman · 2020-01-13T08:35:28Z

charts/hawkbit-update-server/values.yaml

+      ## Configuration for the device management federation
+      ## ref: https://www.eclipse.org/hawkbit/apis/dmf_api/
+      dmf:
+        hono:


The following configuration requires eclipse-hawkbit/hawkbit#890 to be merged. I'm not sure, if we should include it right away, since 0.3.0-M5 doesn't support it?

I'm way unsure, but might you mean this PR eclipse-hawkbit/hawkbit#865?

The properties in this section are not supported by hawkBit as of now. They will be introduced with eclipse-hawkbit/hawkbit#890 as they configure Hono to be used as device registry for hawkBit via DMF. As these properties will have no effect at the moment, I was wondering whether to exclude them for now.

I commented the properties and added a reference to the related PR.
Is this okay for you?

charts/hawkbit-update-server/README.md

monotek · 2020-01-15T11:01:55Z

Please don't merge. I want to try to fix the ci. Currently pvc were disabled.

monotek · 2020-01-15T11:53:44Z

CI works now with persistence by using a forked kind action https://github.com/eclipse/packages/pull/18/files#diff-60fe268f71ae7f8409aff40d0a3e51d8R61

I've create a pr at the helm folks kind action repo to get it merged: helm/kind-action#16

Not sure if we want to go with my temporary version or wait for their merge.

ctron · 2020-01-16T08:30:48Z

Let's wait a day or two and see how it goes.

ctron · 2020-01-16T08:57:37Z

On another topic: When using the original helm charts for hawkbit from kiwigrid, I had to make some changes to be able to run with non-root containers. Is root still a requirement, or can we maybe get rid of that requirement from the start? I made a few modifications in order to drop the requirement, but I don't want to mess up your efforts 😉

monotek · 2020-01-16T10:01:37Z

+1 for non root

As we're waiting anyway, we could maybe add the changes here?

Do you have a link to your changes?

ctron · 2020-01-16T15:21:21Z

Not to the changes, but to the content: https://github.com/ctron/hawkbit-kubernetes

sophokles73 · 2020-01-17T08:18:27Z

@axdotl @monotek This PR now seems to contain arbitrary changes to all kinds of artifacts, e.g. the general IoT Packages README, the CI pipeline and, last but not least, the hawkBit chart itself which originally seemed to be the subject of this PR :-)
I would appreciate if we could create separate PRs for the former two things as they do not seem to be related to the hawkBit chart per se, or are they?

monotek · 2020-01-17T08:32:52Z

Sure, no problem. I will create separate pr for the ci stuff.

monotek · 2020-01-17T13:06:28Z

i've created the pr: #23

axdotl · 2020-01-17T19:29:54Z

@sophokles73 With respect to the charts/README.md: @laverman asked for some info about a local setup. As this is similar to the setup described in the README of the Ditto chart, I assumed that this might be true for all charts in the package project. That's why I decided to provide some general info about a local setup.
What do you think: Should I move it to charts/hawkbit/README.md or should it remain in current location?

Next to that I followed @sophokles73 advice and reverted the CI related changes.

What do you think - can we proceed and get this PR merged once @laverman re-reviewed it?

monotek

I still think persistence should be enabled by default.
Using empty dir is potentially dangerous and should only be used if you activly enable it.

ctron · 2020-01-22T14:15:36Z

Could you re-base the PR?

ctron · 2020-01-23T07:35:13Z

I added a small PR for this PR -> kiwigrid#1 … This drops the default requirement to run as user 1001, and lets the cluster assign a random user uid, which makes it work on OpenShift. You can of course always re-enable the uid 1001 requirement.

monotek · 2020-01-23T11:50:15Z

I've added the needed stuff to run the container as non root user now.

But as already mentioned in the comment to your pr (kiwigrid#1 (review)) i don't like to disable this by default.

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

ctron

I still think the PR needs a rebase, but 👍 in any case.

monotek · 2020-01-23T13:45:01Z

I still think the PR needs a rebase, but in any case.

done.

ctron · 2020-01-23T14:00:26Z

Yay! Thanks for all the work!

axdotl requested review from calohmn and ctron as code owners January 9, 2020 13:20

thjaeckle requested a review from laverman January 9, 2020 13:25

laverman reviewed Jan 13, 2020

View reviewed changes

This was referenced Jan 13, 2020

Target registry option: Eclipse Hono eclipse-hawkbit/hawkbit#890

Closed

Please provide ability to configure Hawkbit after deployment kiwigrid/helm-charts#270

Closed

axdotl force-pushed the hawkbit branch from 2a9860b to a9a4699 Compare January 15, 2020 08:29

axdotl mentioned this pull request Jan 15, 2020

Add Hono 1.0.2 #13

Closed

axdotl force-pushed the hawkbit branch 5 times, most recently from ff8d458 to 3790337 Compare January 15, 2020 10:35

monotek mentioned this pull request Jan 15, 2020

update kind to 0.7.0 helm/kind-action#16

Merged

axdotl force-pushed the hawkbit branch from b66568e to eb472fb Compare January 17, 2020 19:39

monotek suggested changes Jan 18, 2020

View reviewed changes

added hawkbit chart

d301c07

Signed-off-by: André Bauer <andre.bauer@kiwigrid.com>

ctron approved these changes Jan 23, 2020

View reviewed changes

monotek force-pushed the hawkbit branch from 558c167 to d301c07 Compare January 23, 2020 13:44

ctron merged commit 71e79fc into eclipse-packages:master Jan 23, 2020

axdotl deleted the hawkbit branch January 23, 2020 14:01

Conversation

axdotl commented Jan 9, 2020

Uh oh!

thjaeckle commented Jan 9, 2020

Uh oh!

monotek commented Jan 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

laverman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

axdotl Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

monotek commented Jan 15, 2020

Uh oh!

monotek commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ctron commented Jan 16, 2020

Uh oh!

ctron commented Jan 16, 2020

Uh oh!

monotek commented Jan 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ctron commented Jan 16, 2020

Uh oh!

sophokles73 commented Jan 17, 2020

Uh oh!

monotek commented Jan 17, 2020

Uh oh!

monotek commented Jan 17, 2020

Uh oh!

axdotl commented Jan 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

monotek left a comment

Choose a reason for hiding this comment

Uh oh!

ctron commented Jan 22, 2020

Uh oh!

ctron commented Jan 23, 2020

Uh oh!

monotek commented Jan 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ctron left a comment

Choose a reason for hiding this comment

Uh oh!

monotek commented Jan 23, 2020

Uh oh!

ctron commented Jan 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

monotek commented Jan 9, 2020 •

edited

Loading

axdotl Jan 15, 2020 •

edited

Loading

monotek commented Jan 15, 2020 •

edited

Loading

monotek commented Jan 16, 2020 •

edited

Loading

axdotl commented Jan 17, 2020 •

edited

Loading

monotek commented Jan 23, 2020 •

edited

Loading