Fixes issue #14 with last set volume not getting saved#19
Fixes issue #14 with last set volume not getting saved#19bbeng89 wants to merge 1 commit intohelloitszak:masterfrom
Conversation
|
Heyo, thanks for the contribution. Might be a few days before I can actually merge and test this, but once I can I'll be sure to cut a release. |
|
No problem! I was a little hesitant to just uncomment that line because I thought you probably commented it out for a reason, but I've been using it all day and haven't encountered any issues. Figured it was maybe just a debugging thing that slipped through the cracks. Anyway, if you find a problem with it just let me know. I don't mind doing the work to fix it. Thanks! |
|
You know it's been so long since I seriously touched this code. I'm not sure anymore. |
|
Any word on this? |
|
I'm still here and I haven't forgotten. Personal life is just a little bit in the way right now. I promise I'll get to this soon. Thanks for your patience. |
|
No worries, I totally understand. Just wanted to check in. Thanks! |
For some reason the line (173) that initialized the saveVolume variable had been commented out, so it was never pulling the last saved volume from local storage. Simply uncommenting this seemed to fix the issue.