Skip to content

Fixes issue #14 with last set volume not getting saved#19

Open
bbeng89 wants to merge 1 commit intohelloitszak:masterfrom
bbeng89:master
Open

Fixes issue #14 with last set volume not getting saved#19
bbeng89 wants to merge 1 commit intohelloitszak:masterfrom
bbeng89:master

Conversation

@bbeng89
Copy link
Copy Markdown

@bbeng89 bbeng89 commented Jul 25, 2017

For some reason the line (173) that initialized the saveVolume variable had been commented out, so it was never pulling the last saved volume from local storage. Simply uncommenting this seemed to fix the issue.

@helloitszak
Copy link
Copy Markdown
Owner

Heyo, thanks for the contribution.

Might be a few days before I can actually merge and test this, but once I can I'll be sure to cut a release.

@bbeng89
Copy link
Copy Markdown
Author

bbeng89 commented Jul 25, 2017

No problem! I was a little hesitant to just uncomment that line because I thought you probably commented it out for a reason, but I've been using it all day and haven't encountered any issues. Figured it was maybe just a debugging thing that slipped through the cracks.

Anyway, if you find a problem with it just let me know. I don't mind doing the work to fix it. Thanks!

@helloitszak
Copy link
Copy Markdown
Owner

You know it's been so long since I seriously touched this code. I'm not sure anymore.
I just need to retrace my steps, hopefully I'll remember what the heck I was thinking at the time.

@bbeng89
Copy link
Copy Markdown
Author

bbeng89 commented Aug 11, 2017

Any word on this?

@helloitszak
Copy link
Copy Markdown
Owner

I'm still here and I haven't forgotten. Personal life is just a little bit in the way right now. I promise I'll get to this soon.

Thanks for your patience.

@bbeng89
Copy link
Copy Markdown
Author

bbeng89 commented Aug 14, 2017

No worries, I totally understand. Just wanted to check in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants