Fix Firefox, add build bits, etc#28
Open
half-duplex wants to merge 3 commits intohelloitszak:masterfrom
Open
Conversation
Owner
|
It's funny I was just talking with some friends the other day about wanting to try and fix this up. Maybe I have a breach somewhere 😉 I'll try and get this merged this week and fix #29 in the process. I don't know who maintains the current FF package, I believe it was forked off of this awhile back and maintained completely separately. From some googling I think it's @DanielKamkha who maintains it? I don't use Firefox as my daily driver, but I'm not opposed to putting this up on AMO. With Safari and Edge using the same format too, I might try to release a build for those as well. Thanks for the contribution, this was just the extra kick in the pants I needed to fix the other stuff. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makefileto easily produce Chrome and FF packagesSmoke tested in FF and Chrome. It looks like the existing AMO package is a somewhat diverged fork last updated 3 years ago that doesn't match any styling. If they aren't around to update it, could one of us repost it?