Add unified core configuration generator with CLI and GUI interfaces#27
Merged
Add unified core configuration generator with CLI and GUI interfaces#27
Conversation
Co-authored-by: helium729 <30749877+helium729@users.noreply.github.com>
Co-authored-by: helium729 <30749877+helium729@users.noreply.github.com>
Co-authored-by: helium729 <30749877+helium729@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] General core generator
Add unified core configuration generator with CLI and GUI interfaces
Jun 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a unified core configuration generator tool with both CLI and GUI interfaces for the VIGNA RISC-V processor, enabling streamlined generation, parsing, and validation of core configurations. Key changes include:
- Implementation of the configuration generator tool (CLI and GUI) in tools/vigna_config_generator.py.
- A comprehensive test suite in tests/test_config_generator.py for generating, parsing, and validating configurations.
- Updated documentation in README.md outlining usage examples, directory structure, and feature support.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_config_generator.py | New tests covering predefined configurations, parsing, CLI, and validation functionality. |
| README.md | Updated documentation with usage examples, interface instructions, and project layout revisions. |
Comments suppressed due to low confidence (1)
README.md:103
- Ensure that the updated directory structure in the README matches the actual project layout and that each tool (e.g., bin_to_verilog_mem.py) is briefly described for clarity.
├── tools/ # 🛠️ Utility scripts
| with open(temp_file, 'r') as f: | ||
| content = f.read() | ||
|
|
||
| if '`ifndef VIGNA_CONF_VH' not in content: |
There was a problem hiding this comment.
Verify that the expected header check in the generated configuration file is correctly specified. If the intended header is '#ifndef VIGNA_CONF_VH', update the check to match it exactly.
Suggested change
| if '`ifndef VIGNA_CONF_VH' not in content: | |
| if '#ifndef VIGNA_CONF_VH' not in content: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a comprehensive configuration generator tool for the VIGNA RISC-V processor, addressing the need for a unified way to generate processor configurations with desired features.
🚀 Features Added
Configuration Generator Tool (
tools/vigna_config_generator.py).vhconfiguration filesSupported Configurations
rv32irv32erv32imrv32icrv32imcrv32im_zicsrrv32imc_zicsr🛠️ Usage Examples
CLI Interface
GUI Interface
# Launch cross-platform GUI python3 tools/vigna_config_generator.py --gui🔧 Technical Details
Configuration Features Supported
Validation & Safety
m_fpga_fastrequiresm_extension)🧪 Testing
Added comprehensive test suite (
tests/test_config_generator.py):📚 Documentation Updates
Updated README.md with:
🔄 Backward Compatibility
.vhfile format anddefinedirectives🌐 Cross-Platform Support
Fixes #26.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com/usr/lib/apt/methods/https(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.