Skip to content

Cleanup#50

Merged
malnick merged 8 commits intomainfrom
cleanup
Oct 7, 2020
Merged

Cleanup#50
malnick merged 8 commits intomainfrom
cleanup

Conversation

@paultyng
Copy link
Copy Markdown
Contributor

@paultyng paultyng commented Oct 6, 2020

  • Rework structure for release
  • Add doc generation

@paultyng paultyng requested a review from malnick October 6, 2020 23:01
@paultyng
Copy link
Copy Markdown
Contributor Author

paultyng commented Oct 6, 2020

Due to the doc generation it surfaced some undocumented schema, also I think some of the examples are a little out of sync with the schema, now that they are files on disk though probably easier to run terraform validate.

@paultyng
Copy link
Copy Markdown
Contributor Author

paultyng commented Oct 6, 2020

I can rebase #46 on this if you want to add it in to the generated version.

Copy link
Copy Markdown
Contributor

@malnick malnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding the docs/index.html, otherwise 👍

Comment thread docs/index.md Outdated
Comment thread docs/index.md
@malnick malnick merged commit 8bb38f1 into main Oct 7, 2020
@malnick malnick deleted the cleanup branch October 7, 2020 00:34
malnick added a commit that referenced this pull request Oct 7, 2020
This reverts commit 8bb38f1.
@malnick malnick mentioned this pull request Oct 7, 2020
@paultyng paultyng restored the cleanup branch October 7, 2020 13:14
@paultyng paultyng deleted the cleanup branch October 7, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants