Skip to content

Add import support, fix testing#52

Merged
malnick merged 2 commits intomainfrom
import
Oct 7, 2020
Merged

Add import support, fix testing#52
malnick merged 2 commits intomainfrom
import

Conversation

@paultyng
Copy link
Copy Markdown
Contributor

@paultyng paultyng commented Oct 7, 2020

Reworking some of the testing to fix CI and also add import support. Still some cleanup work to do.

@paultyng
Copy link
Copy Markdown
Contributor Author

paultyng commented Oct 7, 2020

@malnick @jefferai this is back to just failing with the global scope issue, unsure what the resolution was for that.

@jefferai
Copy link
Copy Markdown
Member

jefferai commented Oct 7, 2020

Not sure what you mean? All tests passed for me before #50 was merged.

Add import steps to test cases
@paultyng paultyng marked this pull request as ready for review October 7, 2020 14:20
@paultyng
Copy link
Copy Markdown
Contributor Author

paultyng commented Oct 7, 2020

Looks green now once I fixed up those destroy checks

Copy link
Copy Markdown
Contributor

@malnick malnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malnick malnick merged commit b4f70a9 into main Oct 7, 2020
@malnick malnick deleted the import branch October 7, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants