Skip to content

Conversation

Copy link

Copilot AI commented Dec 25, 2025

Plan: Fix ObjDetCount Blinking Behavior

Problem Analysis

  • Understand current behavior: Node only blinks on threshold crossing (edge transition)
  • Current issue: When count is at +100 (within threshold), no blinking occurs
  • Root cause: trigger_active is only True during edge transitions, not while within threshold

Solution

  • Change blinking logic to activate whenever count is within the threshold range
  • Keep the threshold crossing trigger output unchanged (for backward compatibility)
  • Separate blinking behavior from trigger output behavior

Implementation Steps

  • Modify _handle_blink_effect to accept within_threshold parameter instead of trigger_active
  • Update blinking to activate when entering threshold and continue while within range
  • Update tests to reflect new blinking behavior
  • Verify existing tests still pass
  • Manual testing to confirm blinking works correctly

Testing

  • Run existing tests to ensure no regression
  • Update blinking tests to reflect new behavior
  • Test with count at +100 to verify blinking occurs
  • Code review and security scan
Original prompt

dans le node objectdetcount, l'affichage est a +100 en count, pourtant, pas de clignottement, verifie et fix


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants