forked from Kazuhito00/Image-Processing-Node-Editor
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix VideoWriter silent initialization failures causing abrupt recording stops #230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
259
commits into
main
Choose a base branch
from
copilot/fix-video-writer-start-issue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timestamp preservation in ImageConcat when collecting audio from multiple slots - Update VideoWriter to synchronize multi-slot audio by timestamp instead of slot order - Add comprehensive tests validating synchronized audio merging - Maintain backward compatibility for audio without timestamps Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
- Move traceback import to top of file
- Add detailed comment for float('inf') usage in timestamp sorting
- Remove specific line numbers from documentation to prevent staleness
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
[WIP] Verify synchronized merging of audio chunks
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…Writer Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
… review Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ssues Fix audio timestamp loss in Video→SyncQueue→ImageConcat→VideoWriter pipeline
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ssing Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…orker Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
[WIP] Implement background video creation to avoid UI freezes
…ssue Fix audio synchronization in VideoWriter multi-slot merging
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…worker Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ing defaults Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Fix YouTube node display failure with playlist URLs
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…nts, and clean up imports Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…ideo-processing Eliminate cascading deepcopy operations causing memory leak in detection→concat→writer pipeline
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
…sues Extend H.264 re-encoding fix from AVI to MKV format
- Changed queue size calculation from fps*chunk_duration*audio_queue_size to fps*chunk_duration - Reduced MAX_FRAME_QUEUE_SIZE from 300 to 100 frames - Reduced MIN_FRAME_QUEUE_SIZE from 50 to 30 frames - This prevents excessive memory allocation on start (from ~2.2 GB to ~534 MB at 1080p) - Added comprehensive test suite to verify memory limits Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
[WIP] Fix lag issues when starting videowriter
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Co-authored-by: hackolite <826027+hackolite@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix abrupt stop issue on video writer start
Fix VideoWriter silent initialization failures causing abrupt recording stops
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VideoWriter could silently fail during initialization (invalid codec, disk space, permissions) but continue execution, causing recordings to appear started while actually stopped immediately.
Changes
Core Fix (
node_video_writer.py)isOpened()validation aftercv2.VideoWritercreationBefore:
After:
Testing (
test_videowriter_initialization_validation.py)Error Scenarios Now Handled:
Impact
Users now receive immediate feedback on initialization failures with crash logs containing diagnostic information. No breaking changes—only adds validation layer.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.