Don't show pointer cursor for Cinemagraphs #15190
Open
+9
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good! When cinemagraphs are used in fronts, the |
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
simonbyford
force-pushed
the
cinemagraph-cursor-fix
branch
from
5637858 to
e90ae5b
Compare
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Second attempt at not showing
cursor: pointerwhen hovering over Cinemagraphs on articles.Why?
My first attempt was overcomplicating things by distinguishing between Cinemagraphs on articles vs fronts.
Cinemagraphs on fronts have their
cursor: pointerapplied further up the tree so this change should only affect Cinemagraphs on articles.Screenshots