Stop showing the pointer cursor when hovering over Cinemagraphs in articles #15163
+37
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbyford
changed the title
simonbyford
force-pushed
the
update-cinemagraph-cursor
branch
from
d7f5502 to
5ea9fbc
Compare
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
domlander
reviewed
Jan 22, 2026
| /* used in custom subtitle overlays */ | ||
| activeCue?: ActiveCue | null; | ||
| letterboxed: boolean; | ||
| isInArticle: boolean; |
Contributor
There was a problem hiding this comment.
Could we use a prop that's more descriptive of the change it will make within this component? This should now be possible given that the max-height restrictions have been removed (Again in #15119). Something like isClickable or isInteractive?
domlander
reviewed
Jan 22, 2026
| subtitleSource?: string; | ||
| subtitleSize: SubtitleSize; | ||
| letterboxed?: boolean; | ||
| isInArticle?: boolean; |
Contributor
There was a problem hiding this comment.
domlander
reviewed
Jan 22, 2026
| * height. Instead, they should be scaled and grey bars should be shown on | ||
| * either side. | ||
| */ | ||
| ${!isInArticle && |
Contributor
Author
|
Thanks for the review @domlander. I think I'm overcomplicating things here. Closing in favour of #15190 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Does two things:
letterboxedprop with a more descriptiveisInArticleprop.isInArticlehas the opposite meaning toletterboxedso the logic was flipped around where appropriate. The reason for this change is thatletterboxedwas a potentially confusing term. Changing it toisInArticlealso enabled the second thing...Why?
Feedback from Mat who rightly pointed out that clicking on a Cinemagraph in an article doesn't do anything and so we shouldn't give the user the impression it does.
Screenshots