Skip to content

consume and show section specific titles#245

Open
JustinH11235 wants to merge 3 commits intogt-scheduler:mainfrom
JustinH11235:main
Open

consume and show section specific titles#245
JustinH11235 wants to merge 3 commits intogt-scheduler:mainfrom
JustinH11235:main

Conversation

@JustinH11235
Copy link
Contributor

Summary

No ticket related.

I noticed for CS 8803 the section title shown was not the sections actual title, it was whatever the first section for CS 8803's title was, which happened to be Computer Law or something.
image

This is because the code only tracks a single title for the course itself, not specific sections. This PR adds that data to the crawler's section type.

Note: I had to add the extra field at the end of the tuple type for compatibility with GT scheduler's frontend parsing because tuples are parsed by their order, not the names of their field. This means you should be able to roll the backend PR first gt-scheduler/crawler-v2#18, then roll this PR to change the frontend. As a side-note, I think this is the disadvantage of using tuples, if these were records, it would likely be easier to upgrade the types.

This is what the final product looks like after both backend and frontend roll:
image

Potential Future Work:

  • You can see on the left pane it still just uses the first section's title for the title of the CS 8803 panel, but... I don't know what else you'd put there, ideally the words "Special Topics" would go there, but I'm not sure where that info is generally available. Regardless, this PR is an improvement.
  • Deprecate the usage of course.title to use the first section's title, so that you can later remove course.title in the backend afterward.

Checklist

yarn lint and format

How to Test

Look at an example like CS 8803.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants