Skip to content

feat: show section-specific titles for 8803#384

Merged
uma-anand merged 7 commits intobog-f25-sprint5from
oliver/issue-382-section-specific-titles
Nov 18, 2025
Merged

feat: show section-specific titles for 8803#384
uma-anand merged 7 commits intobog-f25-sprint5from
oliver/issue-382-section-specific-titles

Conversation

@Oliver-Zen
Copy link
Contributor

Summary

Resolves #382

This PR makes the following 4 places show correct section title as course name for 8803 special topics courses:

  1. SectionBlocks
  2. CompareBlocks
  3. Map list
  4. Calendar export text

Note: Merge Order

Merge this PR after the corresponding backend PR.
This PR includes a fallback, so merging out of order won’t break builds, but this order is preferred.

Checklist

  • fix: Special Topics courses show incorrect titles

How to Test

yarn start
  1. SectionBlocks
image
  1. CompareBlocks
image
  1. Map list
image
  1. Calendar export text
image

@github-actions
Copy link

github-actions bot commented Oct 28, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://gt-scheduler.github.io/website/pr-preview/pr-384/

Built to branch gh-pages at 2025-11-18 15:31 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@Oliver-Zen Oliver-Zen requested a review from uma-anand October 28, 2025 22:59
@Oliver-Zen
Copy link
Contributor Author

Oliver-Zen commented Nov 12, 2025

3 Major Changes

  1. No more hard coding 8803 checking: isMultipleTopics is computed once when the course bean is built, so every component (SectionBlocks, CompareBlocks, Map, Calendar export) can reuse the same answer without re-scanning the sections list.
  2. Course / Section title fetching logic is encapsulated and put into utils/misc.tsx
  3. Fixed map ALL day ActionRow's issue, now it shows all unique sections' titles if user registers more than one multi-topic section, instead of the first section's title

Tests

image
  • "Multiple Topics" shown as course title
  • Each section block has its own course name
  • Same for CompareBlocks
  • Calendar export text shows section specific names
image
  • Each special topic section has its own entry in ALL day ActionRow

@Oliver-Zen
Copy link
Contributor Author

Oliver-Zen commented Nov 13, 2025

Updated frontend code based on the code changes of crawler.

@uma-anand uma-anand changed the base branch from bog-f25-sprint4 to bog-f25-sprint5 November 18, 2025 15:22
@uma-anand uma-anand merged commit ece1fcc into bog-f25-sprint5 Nov 18, 2025
3 checks passed
@uma-anand uma-anand deleted the oliver/issue-382-section-specific-titles branch November 18, 2025 15:31
uma-anand added a commit that referenced this pull request Dec 27, 2025
### Summary

Resolves #382 

<!-- What does this PR change and why? Discuss any breaking changes. -->
This PR makes the following 4 places show correct **section title** as
**course name** for 8803 special topics courses:
1. SectionBlocks
2. CompareBlocks
3. Map list
4. Calendar export text

### Note: Merge Order
Merge **this** PR after the [corresponding backend
PR](gt-scheduler/crawler-v2#46).
This PR includes a fallback, so merging out of order won’t break builds,
but this order is preferred.

### Checklist

- [x] fix: Special Topics courses show incorrect titles


### How to Test
<!-- Describe how to test your code. -->
```zsh
yarn start
```
1. SectionBlocks
<img width="334" height="216" alt="image"
src="https://github.com/user-attachments/assets/d9cb531b-931a-4c6a-8cc7-c419b1538998"
/>

2. CompareBlocks
<img width="362" height="238" alt="image"
src="https://github.com/user-attachments/assets/93b68480-eb4c-4b30-8cbb-d12509e14ead"
/>

3. Map list
<img width="273" height="164" alt="image"
src="https://github.com/user-attachments/assets/559ad8dd-8df7-4209-87ad-79db0634ce27"
/>

4. Calendar export text
<img width="379" height="130" alt="image"
src="https://github.com/user-attachments/assets/2526d38a-4d6e-4de4-8d71-d24bb506449d"
/>

---------

Co-authored-by: Uma Anand <63426041+uma-anand@users.noreply.github.com>
Co-authored-by: Uma Anand <uma2005anand@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants