fix(ollama): missing streamSimple, broken theme color, instant UI dismiss#3425
Open
tosoyn wants to merge 2 commits intogsd-build:mainfrom
Open
fix(ollama): missing streamSimple, broken theme color, instant UI dismiss#3425tosoyn wants to merge 2 commits intogsd-build:mainfrom
tosoyn wants to merge 2 commits intogsd-build:mainfrom
Conversation
The unknown-command fallback added in 91f0286 returns true for any unrecognised "/" input before the extension system gets a chance to handle it. This breaks every extension-registered command (/gsd, /kill, /worktree, /exit, etc.). Check extensionRunner.getCommand() before showing the error so that extension commands fall through to session.prompt() as intended. Affects: main branch at 394cb18 (HEAD), not yet in any npm release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…d broken UI Three issues in the Ollama extension added in 778d6ac prevent it from working on current main (394cb18): 1. registerProvider("ollama", { authMode: "none" }) without streamSimple. Commit 91f0286 made streamSimple mandatory for keyless providers. Fix: add streamSimple wrapping streamOpenAICompletions with a dummy apiKey ("ollama") since Ollama needs no auth. 2. theme.fg("fg", ...) uses non-existent theme color "fg". Fix: replace with "text" which is a valid ThemeColor. 3. ctx.ui.custom() returns immediately via setTimeout(() => done(), 0), causing the UI to flash and disappear. Also returns a Text component instead of the expected { render, handleInput, invalidate } contract. Fix: return proper component object that waits for keypress to dismiss. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🔴 PR Risk Report — CRITICAL
Affected Systems
File Breakdown
|
Collaborator
|
@tosoyn please fix Ci issues. |
Collaborator
|
This PR has merge conflicts with the base branch. Please rebase or merge 🤖 Automated PR audit — 2026-04-04 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3424
Three issues in the Ollama extension (
778d6ac, PR #3371) that prevent it from working on currentmain(394cb18):registerProviderwithauthMode: "none"now requiresstreamSimple(enforced since91f0286). Added wrapper aroundstreamOpenAICompletionswith dummy apiKeytheme.fg("fg", ...)→theme.fg("text", ...)(3 occurrences)ctx.ui.custom()usedsetTimeout(() => done(), 0)and returned aTextcomponent. Now returns{ render, handleInput, invalidate }contract, waits for keypressAffected version:
mainat394cb18. Not in npm v2.58.0.Test plan
gsdfrom patchedmainwith Ollama running/modelsopens without crash, ollama models visible in "all" scope/ollamashows status and stays visible until keypress/ollama listshows models and stays visible until keypress/ollama psshows running models (if any loaded)/ollama pull <model>pulls with progress🤖 Generated with Claude Code