fix: use authMode apiKey for Ollama provider to avoid streamSimple crash (#3440)#3443
Open
Codergoterrors wants to merge 1 commit intogsd-build:mainfrom
Open
Conversation
…ash (gsd-build#3440) authMode 'none' now requires a streamSimple handler in model-registry.ts. Ollama doesn't provide one, causing a crash when opening /model selector. Fix: switch to authMode 'apiKey' with a dummy apiKey value of 'ollama'. Ollama ignores authentication keys entirely, so this has no functional impact but satisfies the new validation in model-registry.ts line 699.
Contributor
🔴 PR Risk Report — CRITICAL
Affected Systems
File Breakdown
|
|
Modified my local CLI with this change and it resolved an issue I was having with logout. I have a local Qwen3 model that was apparently causing the issue. What's interesting, or annoying, is I was trying to login and logout of my claude code session and this was blocking that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3440
Problem
model-registry.tsline 699 now requiresstreamSimplewhenauthModeis"none". The Ollama extension registers withauthMode: "none"but nostreamSimplehandler → crash whenopening
/modelselector with Ollama running.Fix
Switch Ollama's provider registration to
authMode: "apiKey"witha dummy
apiKey: "ollama". Ollama ignores authentication entirely,so this has zero functional impact but satisfies the new validation.
Testing