Skip to content

Fix Docker-in-Docker by adding /var/lib/docker volume #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gricha merged 1 commit into from
Jan 7, 2026
Merged

Fix Docker-in-Docker by adding /var/lib/docker volume #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions perry/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ RUN curl -fsSL https://claude.ai/install.sh | bash

RUN curl -fsSL https://opencode.ai/install | bash

RUN bunx playwright install chromium --with-deps

USER root

ENV PATH="/home/workspace/.opencode/bin:${PATH}"
Expand Down
25 changes: 23 additions & 2 deletions src/workspace/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,14 +539,22 @@ export class WorkspaceManager {
containerEnv.WORKSPACE_REPO_URL = clone;
}

const dockerVolumeName = `${VOLUME_PREFIX}${name}-docker`;
if (!(await docker.volumeExists(dockerVolumeName))) {
await docker.createVolume(dockerVolumeName);
}

const containerId = await docker.createContainer({
name: containerName,
image: workspaceImage,
hostname: name,
privileged: true,
restartPolicy: 'unless-stopped',
env: containerEnv,
volumes: [{ source: volumeName, target: '/home/workspace', readonly: false }],
volumes: [
{ source: volumeName, target: '/home/workspace', readonly: false },
{ source: dockerVolumeName, target: '/var/lib/docker', readonly: false },
],
ports: [{ hostPort: sshPort, containerPort: 22, protocol: 'tcp' }],
labels: {
'workspace.name': name,
Expand Down Expand Up @@ -620,14 +628,22 @@ export class WorkspaceManager {
containerEnv.WORKSPACE_REPO_URL = workspace.repo;
}

const dockerVolumeName = `${VOLUME_PREFIX}${name}-docker`;
if (!(await docker.volumeExists(dockerVolumeName))) {
await docker.createVolume(dockerVolumeName);
}

const containerId = await docker.createContainer({
name: containerName,
image: workspaceImage,
hostname: name,
privileged: true,
restartPolicy: 'unless-stopped',
env: containerEnv,
volumes: [{ source: volumeName, target: '/home/workspace', readonly: false }],
volumes: [
{ source: volumeName, target: '/home/workspace', readonly: false },
{ source: dockerVolumeName, target: '/var/lib/docker', readonly: false },
],
ports: [{ hostPort: sshPort, containerPort: 22, protocol: 'tcp' }],
labels: {
'workspace.name': name,
Expand Down Expand Up @@ -695,6 +711,7 @@ export class WorkspaceManager {

const containerName = getContainerName(name);
const volumeName = `${VOLUME_PREFIX}${name}`;
const dockerVolumeName = `${VOLUME_PREFIX}${name}-docker`;

if (await docker.containerExists(containerName)) {
await docker.removeContainer(containerName, true);
Expand All @@ -704,6 +721,10 @@ export class WorkspaceManager {
await docker.removeVolume(volumeName, true);
}

if (await docker.volumeExists(dockerVolumeName)) {
await docker.removeVolume(dockerVolumeName, true);
}

await this.state.deleteWorkspace(name);
}

Expand Down