Fix Docker-in-Docker by adding /var/lib/docker volume#24
Merged
Conversation
Two changes:
1. Add /var/lib/docker volume mount to workspace containers
- Without this, nested Docker tries to use overlay-on-overlay which fails
- This matches the original subroutinecom/workspace behavior
- Creates workspace-{name}-docker volume alongside workspace-{name} volume
- Volume is cleaned up on workspace deletion
2. Pre-install Playwright Chromium in workspace image
- Enables running Playwright tests inside workspaces
- Only dependency that was missing for full Perry development
With these changes, the full Perry validation loop (bun run validate)
works inside a workspace, enabling Perry-in-Perry development.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var/lib/dockervolume mount to workspace containers, fixing Docker-in-DockerProblem
DinD was broken because Perry only mounted
/home/workspaceas a volume. Without/var/lib/dockeron a real volume, nested Docker tries overlay-on-overlay which fails with "invalid argument".The original subroutinecom/workspace project mounted three volumes including
/var/lib/docker- this was missing in Perry.Changes
src/workspace/manager.tsworkspace-{name}-dockervolume alongside existing home volume/var/lib/dockerin containerperry/Dockerfilebunx playwright install chromium --with-depsfor web testing supportTest plan
bun run validatepasses (101 tests + 20 Playwright)docker run --rm hello-worldworks inside workspace🤖 Generated with Claude Code