Skip to content

Optimize test performance: consolidate credentials tests #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gricha merged 1 commit into from
Jan 7, 2026
Merged

Optimize test performance: consolidate credentials tests #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 95 additions & 201 deletions test/integration/credentials.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,151 +4,51 @@ import path from 'path';
import os from 'os';
import { startTestAgent, generateTestWorkspaceName, type TestAgent } from '../helpers/agent';

describe('Credential Injection - Environment Variables', () => {
let agent: TestAgent;
let workspaceName: string;

beforeAll(async () => {
agent = await startTestAgent({
config: {
credentials: {
env: {
TEST_API_KEY: 'test-secret-key-123',
GITHUB_TOKEN: 'ghp_testtoken',
},
files: {},
},
},
});
}, 60000);

afterAll(async () => {
if (agent) {
await agent.cleanup();
}
});

beforeEach(() => {
workspaceName = generateTestWorkspaceName();
});

afterEach(async () => {
try {
await agent.api.deleteWorkspace(workspaceName);
} catch {
// Ignore
}
});

it('injects environment variables into workspace', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(containerName, ['bash', '-c', 'echo $TEST_API_KEY'], {
user: 'workspace',
});

expect(result.stdout.trim()).toBe('test-secret-key-123');
}, 120000);

it('injects multiple environment variables', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(containerName, ['bash', '-c', 'echo $GITHUB_TOKEN'], {
user: 'workspace',
});

expect(result.stdout.trim()).toBe('ghp_testtoken');
}, 120000);
});

describe('Credential Injection - Files', () => {
describe('Credential Injection', () => {
let agent: TestAgent;
let workspaceName: string;
let tempDir: string;
let testFilePath: string;
let privateKeyPath: string;
let publicKeyPath: string;
let postStartScriptPath: string;

beforeAll(async () => {
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'ws-cred-files-'));
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'ws-cred-test-'));

testFilePath = path.join(tempDir, 'test-config.txt');
await fs.writeFile(testFilePath, 'test-config-content');

agent = await startTestAgent({
config: {
credentials: {
env: {},
files: {
'~/.test-config': testFilePath,
},
},
},
});
}, 60000);

afterAll(async () => {
if (agent) {
await agent.cleanup();
}
if (tempDir) {
await fs.rm(tempDir, { recursive: true, force: true });
}
});

beforeEach(() => {
workspaceName = generateTestWorkspaceName();
});

afterEach(async () => {
try {
await agent.api.deleteWorkspace(workspaceName);
} catch {
// Ignore
}
});

it('copies files into workspace', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(containerName, ['cat', '/home/workspace/.test-config'], {
user: 'workspace',
});

expect(result.stdout.trim()).toBe('test-config-content');
}, 120000);
});

describe('Credential Injection - SSH Keys', () => {
let agent: TestAgent;
let workspaceName: string;
let tempDir: string;
let privateKeyPath: string;
let publicKeyPath: string;

beforeAll(async () => {
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'ws-ssh-keys-'));
privateKeyPath = path.join(tempDir, 'id_test');
publicKeyPath = path.join(tempDir, 'id_test.pub');

await fs.writeFile(privateKeyPath, 'FAKE_PRIVATE_KEY_CONTENT');
await fs.writeFile(publicKeyPath, 'ssh-ed25519 AAAAC... test@test.local');

postStartScriptPath = path.join(tempDir, 'post-start.sh');
await fs.writeFile(
postStartScriptPath,
`#!/bin/bash
echo "POST_START_RAN" > /home/workspace/.post-start-marker
`
);
await fs.chmod(postStartScriptPath, 0o755);

agent = await startTestAgent({
config: {
credentials: {
env: {},
env: {
TEST_API_KEY: 'test-secret-key-123',
GITHUB_TOKEN: 'ghp_testtoken',
},
files: {
'~/.test-config': testFilePath,
'~/.ssh/id_test': privateKeyPath,
'~/.ssh/id_test.pub': publicKeyPath,
},
},
scripts: {
post_start: postStartScriptPath,
},
},
});
}, 60000);
Expand All @@ -174,101 +74,95 @@ describe('Credential Injection - SSH Keys', () => {
}
});

it('copies SSH keys with correct permissions', async () => {
await agent.api.createWorkspace({ name: workspaceName });
describe('Environment Variables', () => {
it('injects environment variables into workspace', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;
const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(
containerName,
['stat', '-c', '%a', '/home/workspace/.ssh/id_test'],
{ user: 'workspace' }
);
const result = await execInContainer(containerName, ['bash', '-c', 'echo $TEST_API_KEY'], {
user: 'workspace',
});

expect(result.stdout.trim()).toBe('600');
}, 120000);
expect(result.stdout.trim()).toBe('test-secret-key-123');
}, 120000);

it('copies public key with correct permissions', async () => {
await agent.api.createWorkspace({ name: workspaceName });
it('injects multiple environment variables', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;
const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(
containerName,
['stat', '-c', '%a', '/home/workspace/.ssh/id_test.pub'],
{ user: 'workspace' }
);
const result = await execInContainer(containerName, ['bash', '-c', 'echo $GITHUB_TOKEN'], {
user: 'workspace',
});

expect(result.stdout.trim()).toBe('644');
}, 120000);
});
expect(result.stdout.trim()).toBe('ghp_testtoken');
}, 120000);
});

describe('Post-start Script Execution', () => {
let agent: TestAgent;
let workspaceName: string;
let tempDir: string;
let scriptPath: string;
describe('Files', () => {
it('copies files into workspace', async () => {
await agent.api.createWorkspace({ name: workspaceName });

beforeAll(async () => {
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), 'ws-poststart-'));
scriptPath = path.join(tempDir, 'post-start.sh');
const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

await fs.writeFile(
scriptPath,
`#!/bin/bash
echo "POST_START_RAN" > /home/workspace/.post-start-marker
`
);
await fs.chmod(scriptPath, 0o755);
const result = await execInContainer(containerName, ['cat', '/home/workspace/.test-config'], {
user: 'workspace',
});

agent = await startTestAgent({
config: {
credentials: {
env: {},
files: {},
},
scripts: {
post_start: scriptPath,
},
},
});
}, 60000);

afterAll(async () => {
if (agent) {
await agent.cleanup();
}
if (tempDir) {
await fs.rm(tempDir, { recursive: true, force: true });
}
expect(result.stdout.trim()).toBe('test-config-content');
}, 120000);
});

beforeEach(() => {
workspaceName = generateTestWorkspaceName();
});
describe('SSH Keys', () => {
it('copies SSH keys with correct permissions', async () => {
await agent.api.createWorkspace({ name: workspaceName });

afterEach(async () => {
try {
await agent.api.deleteWorkspace(workspaceName);
} catch {
// Ignore
}
const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(
containerName,
['stat', '-c', '%a', '/home/workspace/.ssh/id_test'],
{ user: 'workspace' }
);

expect(result.stdout.trim()).toBe('600');
}, 120000);

it('copies public key with correct permissions', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(
containerName,
['stat', '-c', '%a', '/home/workspace/.ssh/id_test.pub'],
{ user: 'workspace' }
);

expect(result.stdout.trim()).toBe('644');
}, 120000);
});

it('executes post-start script', async () => {
await agent.api.createWorkspace({ name: workspaceName });
describe('Post-start Script', () => {
it('executes post-start script', async () => {
await agent.api.createWorkspace({ name: workspaceName });

const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;
const { execInContainer } = await import('../../src/docker');
const containerName = `workspace-${workspaceName}`;

const result = await execInContainer(
containerName,
['cat', '/home/workspace/.post-start-marker'],
{ user: 'workspace' }
);
const result = await execInContainer(
containerName,
['cat', '/home/workspace/.post-start-marker'],
{ user: 'workspace' }
);

expect(result.stdout.trim()).toBe('POST_START_RAN');
}, 120000);
expect(result.stdout.trim()).toBe('POST_START_RAN');
}, 120000);
});
});