Optimize test performance: consolidate credentials tests#17
Merged
Conversation
Previously, credentials.test.ts had 4 separate describe blocks, each starting its own test agent (~3s startup each). This consolidates them into a single describe block with one shared agent. Expected CI improvement: ~30s savings in test duration. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
credentials.test.tsfrom 4 separate describe blocks (each with its own agent) to 1 describe block with a shared agentBackground
The
testCI job was taking ~6 minutes. Investigation showed:credentials.test.tswas particularly inefficient with 4 separate agentsImpact
Future optimizations considered (but deferred):
cli.test.ts(risky - tests explicitly test create/delete)Test plan
🤖 Generated with Claude Code