Skip to content

Comments

Change: move filtered counts into print_report_xml_start context#2776

Merged
greenbonebot merged 1 commit intomainfrom
smaller-print-report-9-1
Feb 19, 2026
Merged

Change: move filtered counts into print_report_xml_start context#2776
greenbonebot merged 1 commit intomainfrom
smaller-print-report-9-1

Conversation

@mattmundell
Copy link
Contributor

What

Move the f_host_* variables from the body of the print_report_xml_start into the ctx struct.

This is a very simple first step,, to keep the patch easy to understand. It only moves the variables.

Note that the NULL inits are redundant but I've kept them in for now, to minimize changes.

Why

I'm reducing the size of the very large print_report_xml_start, to make it easier to maintain.

References

Follows /pull/2693.

Breakdown of /pull/2712.

Testing

I ran GET_REPORTS on branch and main, and compared the output.

o m m '<get_reports report_id="82f3531c-43cd-4453-8300-990dc423d96b" filter="apache levels=hm" details="1"/>' > /tmp/r-pr
o m m '<get_reports report_id="82f3531c-43cd-4453-8300-990dc423d96b" filter="apache levels=hm" details="1"/>' > /tmp/r-main
o m m '<get_reports details="1"/>' > /tmp/r2-pr
o m m '<get_reports details="1"/>' > /tmp/r2-main
diff -u /tmp/r-pr /tmp/r-main
diff -u /tmp/r2-pr /tmp/r2-main

@mattmundell mattmundell requested review from a team as code owners February 18, 2026 09:49
@greenbonebot greenbonebot enabled auto-merge (rebase) February 18, 2026 09:49
This is a very simple first step, to keep the patch easy to understand. It just
moves the f_host_* variables from the body of the function to the ctx struct.

The NULL inits are redundant but I've kept them in for now, to minimize changes.
@bjoernricks bjoernricks force-pushed the smaller-print-report-9-1 branch from 7d9e36f to 21c3a7c Compare February 19, 2026 06:38
@greenbonebot greenbonebot merged commit 3c94aaa into main Feb 19, 2026
31 of 32 checks passed
@greenbonebot greenbonebot deleted the smaller-print-report-9-1 branch February 19, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants