Change: remove redundant inits in print_report_xml_start#2781
Open
mattmundell wants to merge 1 commit intomainfrom
Open
Change: remove redundant inits in print_report_xml_start#2781mattmundell wants to merge 1 commit intomainfrom
mattmundell wants to merge 1 commit intomainfrom
Conversation
ctx is initialized with `print_report_context_t ctx = {0};`, which ensures that
all fields are 0 (which is NULL for pointers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove inits of
ctx.f_host_*inprint_report_xml_start.I'm making this a very small change, to keep review easier. This function is big and messy.
Why
They are redundant.
ctx is initialized with
print_report_context_t ctx = {0};, which ensures that all fields are 0 (which is NULL for pointers).References
Follows /pull/2776.
Breakdown of /pull/2712.
Testing
I ran GET_REPORTS on branch and main, and compared the output.